Skip to content

fix: correct type export to use .d.ts extension #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: correct type export to use .d.ts extension #924

merged 1 commit into from
Apr 5, 2024

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Apr 5, 2024

Since v15 era, looks like related to #909
And for my case, this is not yet fixed in v15.4.1(#923)

I'm not an expert for this domain, but in my understanding, omitting extensions for .d.ts expect the related .js. Currently there is no schema.js in the package. microsoft/TypeScript#48508 (comment)


Before the change?

After the change?

  • image
  • image

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Contributor

github-actions bot commented Apr 5, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 changed the title fix: clarify to export types from schema.d.ts fix: correct type export to use .d.ts extension Apr 5, 2024
@wolfy1339 wolfy1339 merged commit a347201 into octokit:main Apr 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 15.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kachick
Copy link
Contributor Author

kachick commented Apr 5, 2024

Thank you!

@kachick kachick deleted the fix-missing-exporting-schema-types branch April 5, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants