chore: add test for exported types in npm package #925
+298
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
commented
Apr 5, 2024
4 tasks
`npm install --save-dev "@arethetypeswrong/cli"`
Extracted from validate:ts as posttest does
kachick
changed the title
@arethetypeswrong/cli@arethetypeswrong/cli
kachick
changed the title
@arethetypeswrong/cli
|
How do you think about adding this tooling? I think adding type assertions, as these tools help with the process of publishing a package. However, I can close this PR if there are any concerns. 🙏 |
|
Thank you! 🙏 |
|
🎉 This PR is included in version 15.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add test for #924
Extracted from the original PR because of adding dev dependency https://github.com/arethetypeswrong/arethetypeswrong.github.io/tree/add0a9e21aee1288a13826f3cd7682840acbdc25/packages/cli
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!