mpi/c: Add each check for count==0 in nonblocking reduce interface #1254
Conversation
* Matches the blocking versions of these interfaces - `iallreduce.c` to match `allreduce.c` - `ireduce.c` to match `reduce.c` - `ireduce_scatter.c` to match `reduce_scatter.c` * Workaround for IMB-NBC benchmark, similar to the workaround in place for the IMB-MPI1 benchmark for the blocking collectives. (cherry picked from commit open-mpi/ompi@96779f6)
|
bot:label:Code-cleanup-low-priority |
|
Build Failed with XL compiler! Please review the log, and get in touch if you have questions. Gist: https://gist.github.com/70410b08e5c2b9aaeb8c98c5af30d562 |
|
Build Failed with GNU compiler! Please review the log, and get in touch if you have questions. Gist: https://gist.github.com/b0376263e8433858abf20cf228f8ba35 |
|
Test FAILed. |
|
bot:ibm:retest |
|
bot:retest |
|
Test PASSed. |
| @@ -93,6 +94,15 @@ int MPI_Iallreduce(const void *sendbuf, void *recvbuf, int count, | |||
| OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME); | |||
| } | |||
|
|
|||
| /* MPI standard says that reductions have to have a count of at least 1, | |||
| * but some benchmarks (e.g., IMB) calls this function with a count of 0. | |||
There was a problem hiding this comment.
Nit pick: IMB doesn't call any non-blocking collectives.
There was a problem hiding this comment.
Actually it does in the latest version - IMB-NBC
There was a problem hiding this comment.
Oh! Do we have that in ompi tests?
Sent from my phone. No type good.
On Jul 19, 2016, at 12:05 PM, Josh Hursey <[email protected]mailto:[email protected]> wrote:
In ompi/mpi/c/iallreduce.chttps://github.com//pull/1254#discussion_r71369569:
@@ -93,6 +94,15 @@ int MPI_Iallreduce(const void *sendbuf, void *recvbuf, int count,
OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME);
}
- /* MPI standard says that reductions have to have a count of at least 1,
\* but some benchmarks (e.g., IMB) calls this function with a count of 0.
Actually it does in the latest version - IMB-NBC
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/1254/files/1d8870db477abf3dfd89581ef581ef82a3b1df99#r71369569, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKRgd7PFQFsQiGUEUB_cVgOnyg_8jtM6ks5qXPWegaJpZM4JDeja.
There was a problem hiding this comment.
No, I ompi-tests has the 3.2.4. The latest is 4.1, which contains RMA and NBC benchmarks - might be good to add to that repo, and make an MTT section for it.
|
Other than the comment nit-pick, 👍 bot:retest |
|
Test FAILed. |
|
Mellanox failure is unrelated. Per discussion on the call today, @artpol84 is investigating. |
iallreduce.cto matchallreduce.cireduce.cto matchreduce.cireduce_scatter.cto matchreduce_scatter.cin place for the IMB-MPI1 benchmark for the blocking collectives.
(cherry picked from commit open-mpi/ompi@96779f6)
open-mpi/ompi#1836