mpi/c: Add each check for count==0 in nonblocking reduce interface #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Failed with XL compiler! Please review the log, and get in touch if you have questions. |
|
bot:ibm:retest |
1 similar comment
|
bot:ibm:retest |
|
Build Failed with XL compiler! Please review the log, and get in touch if you have questions. Gist: https://gist.github.com/e24b58727bdea428614e1cabb0789fc1 |
|
:bot:retest |
|
:bot:retest:mellanox |
* Matches the blocking versions of these interfaces - `iallreduce.c` to match `allreduce.c` - `ireduce.c` to match `reduce.c` - `ireduce_scatter.c` to match `reduce_scatter.c` * Workaround for IMB-NBC benchmark, similar to the workaround in place for the IMB-MPI1 benchmark for the blocking collectives.
jjhursey
force-pushed
the
topic/coll-nbc-0-count-ireduce
branch
from
52e0034 to
96779f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IMB-NBC benchmark uses a count == 0 for the first test of the three reduce operations:
We have an early check for this in the blocking versions of those collectives, this patch copies that functionality to the nonblocking interface as well. This allows the collective components that provide these nonblocking interface to not have to worry about this non-standard compliant use case.