Fix intercommunicator split (was triggered by MPICH/icsend test) #1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The remote_size was dropped because it provided duplicate information. Looks like something was missed when I changed that. Are we missing a split of intercommunicators in our MTT tests? Anyway, I think this looks good. It will need to be PR'd to 2.x once it is in master. |
|
@hjelmn Ok. |
artpol84
added a commit
that referenced
this pull request
Dec 8, 2015
Fix intercommunicator split (was triggered by MPICH/icsend test)
artpol84
added a commit
to artpol84/ompi
that referenced
this pull request
Dec 29, 2015
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
mtl/ofi: Change default provider selection behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hjelmn
Nathan, it seems that you've introduced remote_group in
ompi_comm_split()in a88b24c. Could you review this fix?With current master I see failures with
icsendMPICH test. This test doesMPI_Comm_splitof inter-communicator.In this case
remote_groupis set to&ompi_mpi_group_null.group:https://github.com/open-mpi/ompi/blob/master/ompi/communicator/comm.c#L511
This leads this condition to trigger since
NULL != &ompi_mpi_group_null.group:https://github.com/open-mpi/ompi/blob/master/ompi/communicator/comm.c#L151:L153
and this drops
remote_sizethat has useful value and was passed through the function arguments.I may be missing your point in a88b24c but it seems that some changes introduced there either:
(a) was later removed; or
(b) seems consistent with this change.