Fix add_proc deadlock. #1237
Merged
Fix add_proc deadlock. #1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Not quite right. If the proc is in the hash table NULL should not be returned. |
Contributor
Author
|
Ah, yes! a typo - will fix that, thank you. |
artpol84
force-pushed
the
add_proc_deadlck_fix
branch
5 times, most recently
from
8bbfbbc to
f11600e
Compare
artpol84
force-pushed
the
add_proc_deadlck_fix
branch
from
f11600e to
6a791c3
Compare
Contributor
Author
|
@hjelmn sorry for the mess. This patch looks right to me. Please review. |
Member
|
Hah, that is one benefit of turning on the locks by default in ompi_proc_t. 👍 |
artpol84
added a commit
to artpol84/ompi
that referenced
this pull request
Dec 29, 2015
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
v2.x missing commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ompi_proc_pack()callsompi_proc_for_name()with lockedompi_proc_lockandompi_proc_for_nametries to acquire this lock too causing a deadlock.@hjelmn, please review.