fix: replace nonexistent wait_until param from playwright page API call#2374
Merged
julianocosta89 merged 5 commits intoopen-telemetry:mainfrom Jul 24, 2025
Merged
fix: replace nonexistent wait_until param from playwright page API call#2374julianocosta89 merged 5 commits intoopen-telemetry:mainfrom
wait_until param from playwright page API call#2374julianocosta89 merged 5 commits intoopen-telemetry:mainfrom
Conversation
brylee10
changed the title
wait_until param from playwright page API callwait_until param from playwright page API call
rogercoll
reviewed
Jul 21, 2025
Contributor
rogercoll
left a comment
rogercoll
left a comment
There was a problem hiding this comment.
Thanks! Would you mind adding an entry to the CHANGELOG.md file for this PR?
julianocosta89
approved these changes
Jul 21, 2025
Member
julianocosta89
left a comment
julianocosta89
left a comment
There was a problem hiding this comment.
Thanks for that!
It looks like this fixes #1800
Contributor
Author
|
Yes I just updated the |
rogercoll
approved these changes
Jul 24, 2025
rnjn
pushed a commit
to base-14/opentelemetry-demo
that referenced
this pull request
Jul 28, 2025
…call (open-telemetry#2374) * fix: remove nonexistent `wait_until` param from playwright page API call * chore: add playwright `wait_until` fix to change log * delete trailing space --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The Python Playwright 1.53
page.clickapi does not have thewait_untilparameter (docs: https://devdocs.io/playwright/api/class-page#page-click). Instead, it provides await_for_load_statefunction (https://devdocs.io/playwright/api/class-page#page-wait-for-load-state). This adds thewait_for_load_statecalls. Without these calls, the API does not wait for the corresponding browser events, as intended.