Skip to content

fix: replace nonexistent wait_until param from playwright page API call #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julianocosta89 merged 5 commits into from
Jul 24, 2025
Merged

fix: replace nonexistent wait_until param from playwright page API call #2374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fc9cde7
fix: remove nonexistent `wait_until` param from playwright page API call
brylee10 Jul 21, 2025
a9951f3
Merge branch 'main' into main
julianocosta89 Jul 22, 2025
efa7064
chore: add playwright `wait_until` fix to change log
brylee10 Jul 23, 2025
1c077f3
Merge branch 'main' into main
julianocosta89 Jul 24, 2025
b57d4be
delete trailing space
julianocosta89 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ the release.
([#2352]((https://github.com/open-telemetry/opentelemetry-demo/pull/2352)))
* [image-provider] Update to latest version of nginx and alpine
([#2369](https://github.com/open-telemetry/opentelemetry-demo/pull/2369))
* [load-generator] Fix Playwright wait until load state error
([#2374](https://github.com/open-telemetry/opentelemetry-demo/pull/2374))

## 2.0.2

Expand Down
6 changes: 4 additions & 2 deletions src/load-generator/locustfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,10 @@ async def add_product_to_cart(self, page: PageWithRetry):
page.on("console", lambda msg: print(msg.text))
await page.route('**/*', add_baggage_header)
await page.goto("/", wait_until="domcontentloaded")
await page.click('p:has-text("Roof Binoculars")', wait_until="domcontentloaded")
await page.click('button:has-text("Add To Cart")', wait_until="domcontentloaded")
await page.click('p:has-text("Roof Binoculars")')
await page.wait_for_load_state("domcontentloaded")
await page.click('button:has-text("Add To Cart")')
await page.wait_for_load_state("domcontentloaded")
await page.wait_for_timeout(2000) # giving the browser time to export the traces
logging.info("Product added to cart successfully")
except Exception as e:
Expand Down
Loading