[Instrumentation.WCF] fix rpc.system tag#837
Merged
Merged
Conversation
dszmigielski
approved these changes
Dec 16, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 77.55% 78.08% +0.53%
==========================================
Files 168 177 +9
Lines 5243 5379 +136
==========================================
+ Hits 4066 4200 +134
- Misses 1177 1179 +2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes N/A
Changes
Adjust tag to otel-spec requierments.
https://github.com/open-telemetry/opentelemetry-specification/blob/5b6d22512ef72214f7cbd52747a1fbfe49f8121f/CHANGELOG.md?plain=1#L611-L612
CHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #