Skip to content

[Instrumentation.WCF] fix rpc.system tag #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeBlanch merged 2 commits into from
Dec 16, 2022
Merged

[Instrumentation.WCF] fix rpc.system tag #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
675a473
[Instrumentation.WCF] fix rpc.system tag
Kielek Dec 16, 2022
ac6b75a
Merge branch 'main' into fix-wcf-tag
CodeBlanch Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

* Update OTel SDK version to `1.3.1`.
([#631](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/631))
* Change value `rpc.system` from `wcf` to `dotnet_wcf`.
([#837](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/837))

## 1.0.0-rc.7

Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Instrumentation.Wcf/Implementation/WcfInstrumentationConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ internal static class WcfInstrumentationConstants
public const string WcfChannelSchemeTag = "wcf.channel.scheme";
public const string WcfChannelPathTag = "wcf.channel.path";

public const string WcfSystemValue = "wcf";
public const string WcfSystemValue = "dotnet_wcf";
}