Default Sampler update + ParentOrElse fix#1013
Merged
CodeBlanch merged 4 commits intoopen-telemetry:masterfrom Aug 5, 2020
Merged
Default Sampler update + ParentOrElse fix#1013CodeBlanch merged 4 commits intoopen-telemetry:masterfrom
CodeBlanch merged 4 commits intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
==========================================
+ Coverage 77.00% 77.01% +0.01%
==========================================
Files 220 220
Lines 6083 6087 +4
==========================================
+ Hits 4684 4688 +4
Misses 1399 1399
|
rajkumar-rangaraj
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default sampler is now ParentOrElse(AlwaysOn) to match the spec: open-telemetry/opentelemetry-specification#750
Fixes ParentOrElse break from #1007.
Relates to #941.