Change the default sampler to ParentOrElse(AlwaysOn)#750
Conversation
1ce0aad to
458a0d5
Compare
|
Because it is the default, you may want to move it to the top of the list. I would also consider adding a new heading "Default Sampler" that specifically calls out that this is the default sampler so it isn't hidden in a bullet list. |
|
@dyladan I pushed some changes that hopefully address the problem here. I have a slight preference for not leading with It felt more right to me to include the default header right next to the documentation of the built-in sampler types rather than adding a new higher level header, but again this is a small preference so happy to split out a separate header as well if you think that is more clear and makes the default more obvious. |
|
|
||
| ### Built-in samplers | ||
| OpenTelemetry supports a number of built-in samplers to choose from. | ||
| The default sampler if one is not specified is `ParentOrElse(AlwaysOn)`. |
There was a problem hiding this comment.
| The default sampler if one is not specified is `ParentOrElse(AlwaysOn)`. | |
| The default sampler if is `ParentOrElse(AlwaysOn)`. |
|
I'm OK with this change, but IMHO it was merged far too fast. #745 suggests to wait two business days, but even without that, I think merging a non-trivial change on the same day it was proposed is unfair. |
|
@Oberon00 my bad. Is there some bot we can install that would block merge for a predefined "public comment" period? Similar to how WIP bot blocks the merge. |
Discussed at the Spec SIG this morning 7/28. Resolves #728