-
Notifications
You must be signed in to change notification settings - Fork 725
otelconf: add unmarshaling and validation for span & cardinality limits #8043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelconf: add unmarshaling and validation for span & cardinality limits #8043
Conversation
Adds unmarshaler code for SpanLimits and CardinalityLimits which require validation to ensure fields are set following the boundaries set by the schema. Signed-off-by: alex boten <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8043 +/- ##
=======================================
+ Coverage 79.6% 79.7% +0.1%
=======================================
Files 187 190 +3
Lines 11833 11912 +79
=======================================
+ Hits 9420 9495 +75
- Misses 2059 2062 +3
- Partials 354 355 +1
🚀 New features to boost your workflow:
|
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
dmathieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. But it seems it should have a changelog entry.
Signed-off-by: alex boten <[email protected]>
changelog added |
|
/easycla |
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Adds unmarshaler code for SpanLimits and CardinalityLimits which require validation to ensure fields are set following the boundaries set by the schema.
Part of breaking up #8026