Skip to content

Conversation

@codeboten
Copy link
Contributor

Adds unmarshaler code for SpanLimits and CardinalityLimits which require validation to ensure fields are set following the boundaries set by the schema.

Part of breaking up #8026

Adds unmarshaler code for SpanLimits and CardinalityLimits which require
validation to ensure fields are set following the boundaries set by the
schema.

Signed-off-by: alex boten <[email protected]>
@codeboten codeboten requested review from a team and pellared as code owners October 20, 2025 18:05
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 94.93671% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.7%. Comparing base (bbc51b2) to head (fee3bbb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
otelconf/config_common.go 90.6% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8043     +/-   ##
=======================================
+ Coverage   79.6%   79.7%   +0.1%     
=======================================
  Files        187     190      +3     
  Lines      11833   11912     +79     
=======================================
+ Hits        9420    9495     +75     
- Misses      2059    2062      +3     
- Partials     354     355      +1     
Files with missing lines Coverage Δ
otelconf/config_json.go 100.0% <100.0%> (ø)
otelconf/config_yaml.go 100.0% <100.0%> (ø)
otelconf/config_common.go 90.6% <90.6%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu added Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG and removed Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG labels Oct 21, 2025
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. But it seems it should have a changelog entry.

Signed-off-by: alex boten <[email protected]>
@codeboten
Copy link
Contributor Author

This looks good. But it seems it should have a changelog entry.

changelog added

@codeboten
Copy link
Contributor Author

/easycla

@MrAlias MrAlias merged commit 1f0bb77 into open-telemetry:main Oct 23, 2025
29 checks passed
@MrAlias MrAlias mentioned this pull request Dec 8, 2025
@MrAlias MrAlias added this to the v1.39.0 milestone Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants