Skip to content

Conversation

@codeboten
Copy link
Contributor

Follow up to #8043, adds unmarshaling for batch processors. Will rebase once #8043 is merged

Part of breaking up #8026

@codeboten codeboten changed the title Codeboten/otelconf batchprocessors otelconf: add unmarshaling / validation for batch processors Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 92.76018% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.8%. Comparing base (4f838f7) to head (2eb2650).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
otelconf/config_common.go 81.8% 6 Missing and 2 partials ⚠️
otelconf/config_json.go 94.4% 3 Missing and 3 partials ⚠️
otelconf/config_yaml.go 97.1% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8049     +/-   ##
=======================================
+ Coverage   79.7%   79.8%   +0.1%     
=======================================
  Files        190     190             
  Lines      11919   12136    +217     
=======================================
+ Hits        9502    9692    +190     
- Misses      2062    2083     +21     
- Partials     355     361      +6     
Files with missing lines Coverage Δ
otelconf/config_yaml.go 97.6% <97.1%> (-2.4%) ⬇️
otelconf/config_json.go 95.1% <94.4%> (-4.9%) ⬇️
otelconf/config_common.go 86.2% <81.8%> (-4.5%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codeboten codeboten force-pushed the codeboten/otelconf-batchprocessors branch from 1d217c5 to df663ee Compare October 23, 2025 20:21
Updates otelconf v1.0.0 to include unmarshaling that validates the fields for batch log processor and batch span processor configuration.

Part of splitting open-telemetry#8026

Signed-off-by: alex boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/otelconf-batchprocessors branch from df663ee to a515b66 Compare October 23, 2025 21:04
@codeboten codeboten marked this pull request as ready for review October 23, 2025 21:05
@codeboten codeboten requested review from a team and pellared as code owners October 23, 2025 21:05
codeboten and others added 10 commits October 24, 2025 10:25
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
@codeboten
Copy link
Contributor Author

Thanks for the suggestions @MrAlias, applied the suggestions PTAL

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only one small nit.

@MrAlias MrAlias merged commit 560975c into open-telemetry:main Oct 24, 2025
29 checks passed
@codeboten codeboten deleted the codeboten/otelconf-batchprocessors branch October 27, 2025 16:50
@MrAlias MrAlias mentioned this pull request Dec 8, 2025
@MrAlias MrAlias added this to the v1.39.0 milestone Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants