-
Notifications
You must be signed in to change notification settings - Fork 725
otelconf: add unmarshaling / validation for batch processors #8049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelconf: add unmarshaling / validation for batch processors #8049
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8049 +/- ##
=======================================
+ Coverage 79.7% 79.8% +0.1%
=======================================
Files 190 190
Lines 11919 12136 +217
=======================================
+ Hits 9502 9692 +190
- Misses 2062 2083 +21
- Partials 355 361 +6
🚀 New features to boost your workflow:
|
1d217c5 to
df663ee
Compare
Updates otelconf v1.0.0 to include unmarshaling that validates the fields for batch log processor and batch span processor configuration. Part of splitting open-telemetry#8026 Signed-off-by: alex boten <[email protected]>
df663ee to
a515b66
Compare
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
|
Thanks for the suggestions @MrAlias, applied the suggestions PTAL |
Signed-off-by: alex boten <[email protected]>
MrAlias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only one small nit.
Co-authored-by: Tyler Yahn <[email protected]>
Follow up to #8043, adds unmarshaling for batch processors. Will rebase once #8043 is merged
Part of breaking up #8026