Repository navigation
fix: record entity identity attributes as required - #346
Open
Utkarsh-Sinha0 wants to merge 3 commits into
Open
Utkarsh-Sinha0 wants to merge 3 commits into
Utkarsh-Sinha0 wants to merge 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-20 20:51 UTC Review the latest changes. Status above doesn't look right?
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set entity identity requirement levels to
requiredinstead of reading the field removed from Weaver's v2 model. Keep the existing identity mapping and add a regression test forprocess.runtimeidentity and description attributes.Fixes #335.
Validation: 75 coverage-model and Weaver lifecycle tests passed on Linux/Python 3.14, after resolving the real pinned registries. Ruff passed for the changed Python file. Cloud validation.
AI-assisted implementation.