Remove network.type from HTTP semconv (changing it from recommended to opt-in)#410
Merged
joaopgrassi merged 2 commits intoopen-telemetry:mainfrom Oct 17, 2023
Merged
Conversation
trask
force-pushed
the
make-network-type-opt-in
branch
from
264879c to
a84c787
Compare
reyang
approved these changes
Oct 16, 2023
lmolkova
approved these changes
Oct 16, 2023
pyohannes
approved these changes
Oct 17, 2023
jsuereth
approved these changes
Oct 17, 2023
joaopgrassi
approved these changes
Oct 17, 2023
jack-berg
approved these changes
Oct 17, 2023
MSNev
approved these changes
Oct 17, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knowing
ipv4vsipv6does not seem to be a useful enough piece of data in the scope of HTTP semconv to capture it by default on all HTTP telemetry.Since there isn't anything to override (brief or note) on
network.type, this attribute is simply removed from http semconv (unlike in #398 and #402 where the attribute is explicitly included as opt-in).Fixes #403
Changes
Changes
network.typefrom recommended to opt-in in the HTTP semconv.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.