Updated samples/optflow/motempl.py file to solve 3 issues.#2269
Merged
alalek merged 3 commits intoopencv:3.4from Sep 23, 2019
Merged
Updated samples/optflow/motempl.py file to solve 3 issues.#2269alalek merged 3 commits intoopencv:3.4from
alalek merged 3 commits intoopencv:3.4from
Conversation
Member
|
As a "bugfix" this patch should go into 3.4 branch first. So, please:
Note: no needs to re-open PR, apply changes "inplace". |
Contributor
Author
|
@alalek I have pushed changes to this |
Member
|
Perhaps push operation was failed. Please ensure that you using |
72e4bdb to
3ab5af6
Compare
Contributor
Author
|
@alalek Sorry, I'm new to this rebase topic. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1) Resolved Syntax error at
line 14:
def draw_motion_comp(vis, (x, y, w, h), angle, color):by adding
line 14:
def draw_motion_comp(vis, rect, angle, color):line 15:
x, y, w, h = rect2) Resolved
TypeError: integer argument expected, got floatChanged division to return integer value instead of float value
by changing from
/to//.3) Released
camvariable in a proper way by adding.release()method by which program is exiting properly. If.release()method is not added, even after destroying all windows program is not get closed.