Simplified generateWindowName #2610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricFlorin
force-pushed
the
VizWindowNamePrepend_Contrib
branch
from
5d0eb21 to
0a3b1af
Compare
I removed lines of code within cv::viz::VizStorage::generateWindowName in an attempt to have "Viz - " prepended to window name automatically.
EricFlorin
force-pushed
the
VizWindowNamePrepend_Contrib
branch
from
0a3b1af to
3705bb9
Compare
|
@EricFlorin Thank you for contribution! I believe we should clarify documentation instead according to issue's description. |
|
Thanks for the review @alalek! I will revert the changes I made and edit the documentation. Give me two to three days because it's been a busy week this week, but I will get it done. |
This reverts commit 3705bb9.
Edited the Viz "getWindowByName" documentation so it reflects the actual behaviour of getWindowByName. More specifically, that "Viz - " is not prefixed automatically to the window name given by the user if they haven't prefixed "Viz - " already.
To restart the buildbot
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes opencv/opencv#10784
Removed a few lines which prevented "Viz - " to be prepended to the names "Viz" and "", as pointed out in the original issue.
Since this issue is 2 years old, I am not sure if it was for an older version of opencv or more recent versions. I believe the 3.4 version of opencv in opencv/opencv may still have the error, since
vizis one of modules packaged with 3.4, but I have not checked it yet.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.