Skip to content

Add calib3d module to Julia binding #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2020

Conversation

archit120
Copy link
Contributor

@archit120 archit120 commented Sep 9, 2020

This PR adds support for the calib3d module in the Julia Bindings. The changelog also demonstrates the changes needed to wrap additional modules. I hope to add a blog post soon detailing this.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
allow_multiple_commits=1

…ation functions with UsacParams parameter; just skip this overloaded variant

* added colors to chessboard_corners.jl sample
@vpisarev
Copy link
Contributor

vpisarev commented Oct 9, 2020

@archit120, thank you! I finally reviewed it. @alalek, I pushed one more commit to archit120/julia_calib3d branch to fix one build problem with UsacParams and also did minor change in one of the examples. For some reason, this new commit does not show up here

@alalek
Copy link
Member

alalek commented Oct 9, 2020

There is incident on GitHub: http://status.github.com/
Need to wait for the service repair.

@vpisarev
Copy link
Contributor

@alalek, thank you! Now the buildbot passed with one error in tracking module; I think, it's not related to the patch.

@opencv-pushbot opencv-pushbot merged commit 37315ba into opencv:master Oct 10, 2020
@archit120
Copy link
Contributor Author

Thank you for the changes @vpisarev I had somehow not run into that error during my testing.

@alalek alalek mentioned this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants