Skip to content

Tbmr features (purely topological adaptation on MSER) #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Nov 18, 2020
Merged

Tbmr features (purely topological adaptation on MSER) #2713

merged 22 commits into from
Nov 18, 2020

Conversation

crownedone
Copy link
Contributor

@crownedone crownedone commented Oct 15, 2020 •
edited by alalek
Loading

Merge with extra: opencv/opencv_extra#817

Some questions:

  • Generalized Component tree calculation could be an additional feature, instead of hiding in the implementation of TBMR (as it can be used by MSER, TBMR, ...). I could do an extra module for that (where)?
  • Is this the right place for TBMR? (In xFeatures2d)

Thanks for your work!

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test
  • The feature is well documented.
  • and sample code can be built with the project CMake

steffen.ehrle added 17 commits October 13, 2020 11:03
initial commit
44c359d
fix test data reusing stereomatching testdata.
a2ee31b
fix incorrect function, ellipse notation, types and comments.
dfc9cf9
add required precomp.hpp, fix warnings.
f34c6a6
fix naming
4f2191c
remove ocl for now. (we want to add opencl functionality later)
c396037
update readme
810eecb
fix invalid module dependency.
4bfebc5
add angle, minAxis and majAxis calculation.
70df975
formatting fixes.
592dd32 
restructure component tree calculation.
remove sort_indexes by using cv::sortIdx.
fix test using virtual data.
fb73bcc
move tbmr to xfeatures2d. Add standard tests in xFeatures2d.
3c59b3c
octave/scale and descriptor extraction using sift added
2eaff86
try fix the errors
3223f46
fix parameter error
64537c6
add scale for pyramid extraction and filter scaled points for duplica…
187d8cb 
…tes.
fix exports
cd2909a
@crownedone
Copy link
Contributor Author

I do not understand, why the builds fail. Its related to python wrapper. Help appreciated!

alalek
alalek requested changes Nov 16, 2020
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep patch clean and minimal for reviewing.

alalek
alalek reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

Please take a look on comments below.

alalek
alalek reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Thank you for updates!

fix warning
ef488ea 
fix correct license text
@crownedone crownedone mentioned this pull request Nov 16, 2020
Merged
alalek
alalek approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@alalek alalek merged commit 672ba70 into opencv:master Nov 18, 2020
@crownedone
Copy link
Contributor Author

Thanks!

@crownedone crownedone deleted the tbmr_features branch November 20, 2020 08:43
@alalek alalek mentioned this pull request Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
category: xfeatures2d feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crownedone @alalek