Added stream support on hough circles, lines and segments #2801
Conversation
- Passed the stream to the different cuda, OpenCV and thurst library calls - Replace all device by cuda synchronizes - Added extra synchronize calls after device to host transfers - Replaced the cuda globals by allocated values
|
|
||
| totalCount = ::min(totalCount, maxSize); | ||
|
|
||
| if (doSort && totalCount > 0) | ||
| { | ||
| thrust::device_ptr<float2> outPtr(out); | ||
| thrust::device_ptr<int> votesPtr(votes); | ||
| thrust::sort_by_key(votesPtr, votesPtr + totalCount, outPtr, thrust::greater<int>()); | ||
| thrust::sort_by_key(thrust::cuda::par.on(stream), votesPtr, votesPtr + totalCount, outPtr, thrust::greater<int>()); |
There was a problem hiding this comment.
Could you please take a look if there is an easy way to guard this code for CUDA 8.x?
There was a problem hiding this comment.
I do not understand your question here.
Is there a problem specific to CUDA 8 ? I have checked the API and it seems fine.
As Cuda 8 is not supported anymore on Ubuntu 18.04 or Visual Studio 19 (my dev tools),
I took some time today to setup an Ubuntu 16.04/CUDA 8 and it builds properly with OpenCV 4.5.0 (master did not on some unrelated problem).
There was a problem hiding this comment.
Please take a look on build issues of "Custom" CUDA builder here.
There are several ways:
- try to fix the build using
#ifguards with CUDA version checks (requested above) - try to fix the build through disabling this algorithm for CUDA 8.0
- open a discussion about deprecation of old CUDA versions in next OpenCV releases (will take some time)
There was a problem hiding this comment.
It should be fixed on my last commit.
I managed to reproduce the build problem, the instruction on the NVIDIA website to install cuda 8 were wrong, I should have checked.
Turns out that the thrust::cuda::par did exist in CUDA 8, but was not included by default.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.