Properly disable xfeatures2d if extra files cannot be downloaded#2815
Closed
asmorkalov wants to merge 2 commits into
Closed
Properly disable xfeatures2d if extra files cannot be downloaded#2815asmorkalov wants to merge 2 commits into
asmorkalov wants to merge 2 commits into
Conversation
Member
|
Check the issue #1301 and this comment. Root cause of configuration failure (broken compilation) is that There are several workarounds:
Proper fix should look like:
Current proposal just hides the problem (which is not a problem in standard normal build environment). With the same success this can be done through |
Contributor
Author
|
@alalek I added extra definitions and guards in code. The module is always enabled, but some classes can be not implemented (exception). |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.