solved issue 2813 #2819
Merged
solved issue 2813 #2819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alalek there is some problem with buildbot? |
alalek
reviewed
Jan 15, 2021
| @@ -113,7 +113,7 @@ class CV_EXPORTS QuasiDenseStereo | |||
| * in case of video processing. | |||
| * @sa loadParameters | |||
| */ | |||
| virtual int loadParameters(cv::String filepath) = 0; | |||
| CV_WRAP virtual int loadParameters(cv::String filepath) = 0; | |||
There was a problem hiding this comment.
Looks like bindings scripts can't properly wrap abstract classes and pure methods.
alalek
reviewed
Jan 21, 2021
| import cv2 as cv | ||
|
|
||
| left_img = cv.imread("G:/Lib/opencv/samples/data/aloeL.jpg", cv.IMREAD_COLOR) | ||
| right_img = cv.imread("G:/Lib/opencv/samples/data/aloeR.jpg", cv.IMREAD_COLOR) |
There was a problem hiding this comment.
Please remove absolute paths. Use command-line parameters with default values.
Use cv.samples.findFile()
alalek
approved these changes
Jan 22, 2021
|
@LaurentBerger |
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2813
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.