Skip to content

#18051 Fix CUDA GoodFeaturesToTrackDetector not threadsafe bug #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nkwangyh
Copy link

@nkwangyh nkwangyh commented Feb 5, 2021

resolves opencv/opencv#18051

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
buildworker:Custom=linux-4,linux-6
build_image:Custom=ubuntu-cuda:16.04

@nkwangyh
Copy link
Author

nkwangyh commented Feb 5, 2021

original issue:CUDA GoodFeaturesToTrackDetector is not ThreadSafe ?
issue

@alalek
Copy link
Member

alalek commented Feb 5, 2021

@nkwangyh Thank you for contribution!

Please amend commit and remove # malformed reference from commit's message (GitHub is not able to make this cross-reference link).
Also please check commit's email - looks like it is not linked to your account (you may want to add secondary emails to GitHub profile)

@llschloesser
Copy link

It'd be nice to have the option for this algorithm to return cv::KeyPoints with response and angle (even if set to 0 initially). cv::cuda::FastFeatureDetector should also fill that role, but it is broken, often never processing the bottom half of a given image.

@nkwangyh
Copy link
Author

@alalek Sorry for the misoperations. I just tried to amend the commit but the pull request is closed unexpectedly. I have amended the commit message and recreated a new pull request. Here is the link. I will update the reference in the issue and pull request.

@nkwangyh nkwangyh reopened this Feb 12, 2021
@nkwangyh nkwangyh closed this Feb 12, 2021
@alalek
Copy link
Member

alalek commented Feb 12, 2021

replaced by #2868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUDA GoodFeaturesToTrackDetector is not ThreadSafe ?
3 participants