Skip to content

Fix omnidir::undistortPoints #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

rgolovanov
Copy link
Contributor

The relevant bug was reported in #1612

The _xi was erroneously applied at points re-projection to camera plane.
_xi parameter was already taken in use while projection of points to unit sphere.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

The relevant bug was reported in opencv#1612

The _xi was erroneously applied at points re-projection to camera plane.
_xi parameter was already taken in use while projection of points to unit sphere.
@llschloesser
Copy link

Is there any value in treating xi as a 5th distortion parameter? It would simplify the interface and allow one to store a pinhole, fisheye, or omni calibration model all in the same data structure (without exposing xi to models that don't care about it).

@rgolovanov
Copy link
Contributor Author

@llschloesser I would consider this suggestion detached from this fix. Could you create separate issue about this?

@llschloesser
Copy link

@rgolovanov , thanks, yes, I will do that.

@opencv-pushbot opencv-pushbot merged commit 974f90f into opencv:master Feb 23, 2021
@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccalib/omnidir undistortPoints result differs from undistortImage.
4 participants