Edge Drawing Improvements #2907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sturkmen72
force-pushed
the
Edge_Drawing_Improvements
branch
8 times, most recently
from
0d8a72e to
ace1239
Compare
sturkmen72
force-pushed
the
Edge_Drawing_Improvements
branch
5 times, most recently
from
51b69b8 to
693db65
Compare
|
@alalek please review |
sturkmen72
force-pushed
the
Edge_Drawing_Improvements
branch
from
693db65 to
98a17f3
Compare
alalek
reviewed
Apr 13, 2021
| @@ -251,6 +332,9 @@ void EdgeDrawingImpl::write(cv::FileStorage& fs) const | |||
| EdgeDrawingImpl::EdgeDrawingImpl() | |||
| { | |||
| params = EdgeDrawing::Params(); | |||
| nfa = new NFALUT(1, 1/2, 1, 1); | |||
| dH = new double[MAX_GRAD_VALUE]; | |||
| grads = new int[MAX_GRAD_VALUE]; | |||
There was a problem hiding this comment.
new
Where are these objects destroyed?
dH, grads
Consider using std::vector for these fields.
sturkmen72
commented
Apr 13, 2021
| @@ -337,6 +338,13 @@ EdgeDrawingImpl::EdgeDrawingImpl() | |||
| grads = new int[MAX_GRAD_VALUE]; | |||
| } | |||
|
|
|||
| EdgeDrawingImpl::~EdgeDrawingImpl() | |||
There was a problem hiding this comment.
is it enough for now ? i am planning to work on optimizing all code later.
sturkmen72
force-pushed
the
Edge_Drawing_Improvements
branch
4 times, most recently
from
429d82c to
f483d27
Compare
sturkmen72
force-pushed
the
Edge_Drawing_Improvements
branch
2 times, most recently
from
0802e7e to
f483d27
Compare
sturkmen72
force-pushed
the
Edge_Drawing_Improvements
branch
from
f483d27 to
8dad620
Compare
alalek
reviewed
Apr 15, 2021
|
|
||
| /* 4. Allocate and initialize arguments for tested function */ | ||
| std::string filename = getDataPath("perf/1680x1050.png"); | ||
| Mat src = imread(filename, 0); |
There was a problem hiding this comment.
0
Please avoid using of magic numbers. Use IMREAD_GRAYSCALE instead.
| int gx = 0; | ||
| int gy = 0; | ||
|
|
||
| switch (op) |
There was a problem hiding this comment.
BTW, "constant" mode switch in inner body of two loops may cause some performance loss.
(in the current patch it is just code move, so we can keep it "as is" in this PR)
|
|
||
| int sum; | ||
|
|
||
| if (SumFlag) |
There was a problem hiding this comment.
if
similar to "constant" mode switch.
sturkmen72
force-pushed
the
Edge_Drawing_Improvements
branch
from
e9794cc to
42288b6
Compare
sturkmen72
force-pushed
the
Edge_Drawing_Improvements
branch
from
42288b6 to
aa850cd
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2314
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
documentation preview