Skip to content

KinFu fix (iss2925) #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2021
Merged

KinFu fix (iss2925) #2926

merged 4 commits into from
Apr 17, 2021

Conversation

DumDereDum
Copy link
Member

Pull Request Readiness Checklist

resolves #2925

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

CV_WRAP virtual void render(OutputArray image, const Matx44f& cameraPose = Matx44f::eye()) const = 0;

CV_WRAP virtual void render(OutputArray image, const Matx44f& cameraPose) const = 0;
//TODO: rewrite render() for 1 and 2 args, like update()/updateT()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this TODO

@savuor savuor self-assigned this Apr 15, 2021
@savuor
Copy link
Contributor

savuor commented Apr 16, 2021

👍

@alalek alalek merged commit 342f892 into opencv:master Apr 17, 2021
@DumDereDum DumDereDum deleted the iss2925 branch April 19, 2021 07:21
@alalek alalek mentioned this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KinFu render() error (python3.8)
3 participants