Skip to content

Fix data type error #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix data type error #2971

wants to merge 2 commits into from

Conversation

Channingss
Copy link
Contributor

@Channingss Channingss commented Jun 10, 2021

Fixes #2911

When the hand is covered, there are too many unicomblock, which resulting in a large m_iNowIdx, but the data type is unsigned short, make data overflow to zero.

and it will fall into an infinite loop:

if (iPosition >= 0 && iPosition < int(m_vcIndex.size()) && 0 == m_vcIndex[iPosition]) {

so we need modify data type from unsigned short to unsigned int.

force_builders=linux,docs

@dddzg
Copy link
Contributor

dddzg commented Jun 10, 2021

Hi, @Channingss . You would better start from a new branch, such as: Channingss:date_type_fixer instead of Channingss:master. And make it into OpenCV master. You can close this one and start a new pr.

@dddzg
Copy link
Contributor

dddzg commented Jun 10, 2021

Fixes #2911

@Channingss
Copy link
Contributor Author

Hi, @Channingss . You would better start from a new branch, such as: Channingss:date_type_fixer instead of Channingss:master. And make it into OpenCV master. You can close this one and start a new pr.

OK, tks

@alalek
Copy link
Member

alalek commented Jun 10, 2021

OpenCV CI doesn't trigger builds automatically from the source "master" branch (due to multi-repositories PRs testing).
Maintainers need to trigger them manually (triggered).

@Channingss
Copy link
Contributor Author

OpenCV CI doesn't trigger builds automatically from the source "master" branch (due to multi-repositories PRs testing).
Maintainers need to trigger them manually (triggered).

OK, so just waiting for Maintainers to trigger them manually.

@Channingss Channingss closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wechat_qrcode exception
3 participants