Skip to content

Pass warping matrix as parameter instead of const memory #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2021
Merged

Pass warping matrix as parameter instead of const memory #3091

merged 1 commit into from
Dec 1, 2021

Conversation

asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented Oct 28, 2021 •
edited by alalek
Loading

  • To exclude data raises if warping is done in different streams
  • Reduce amount of syscalls and memory transactions

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
buildworker:Custom=linux-4,linux-6
build_image:Custom=ubuntu-cuda:16.04

@asmorkalov
Copy link
Contributor Author

/cc @JulieBar

JulieBar
JulieBar approved these changes Nov 8, 2021
View reviewed changes
Copy link

@JulieBar JulieBar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/cudawarping/src/cuda/warp.cu

return make_float2(xcoo, ycoo);
}
struct Coefficients
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can re-use common Coefficients for both structs?

@opencv-pushbot opencv-pushbot merged commit 47f13d7 into opencv:4.x Dec 1, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
@angelo-martinovic angelo-martinovic mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulieBar JulieBar JulieBar approved these changes

Assignees

@JulieBar JulieBar

Labels
category: cuda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asmorkalov @JulieBar @opencv-pushbot