Skip to content

Viz3d sample fixes for python (sample 02 and 03) #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2021
Merged

Viz3d sample fixes for python (sample 02 and 03) #3094

merged 1 commit into from
Oct 31, 2021

Conversation

onuralpszr
Copy link
Contributor

@onuralpszr onuralpszr commented Oct 31, 2021 •
edited
Loading

  • Fixes multiple old viz function into new name
  • Fix opencv bunny path for viz sample 3
  • Fix viz sample 2 for proper cube rotation and example video is in here1

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@onuralpszr
- Fixes multiple old viz function into new name
0d37127 
- Fix opencv bunny path for viz sample 3
- Fix viz sample 2 for proper rotation based on video in here[1]

[1]: https://docs.opencv.org/4.5.3/d8/df0/tutorial_widget_pose.html
alalek
alalek approved these changes Oct 31, 2021
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍

@opencv-pushbot opencv-pushbot merged commit a26f713 into opencv:master Oct 31, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
bug category: python bindings category: samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onuralpszr @alalek @opencv-pushbot