Skip to content

Add regression test for remap in case of overflow #3095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

JulieBar
Copy link

@JulieBar JulieBar commented Nov 1, 2021

Related issue: opencv/opencv#18224
Related fix in OpenCV: opencv/opencv#20977

Fix as well as the issue addressed only BORDER_CONSTANT case; maybe later we should check issues for other borders too;

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
buildworker:Custom=linux-4,linux-6
Xbuild_image:Custom=ubuntu-cuda:16.04
build_image:Custom=ubuntu-cuda:18.04

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@alalek
Copy link
Member

alalek commented Nov 12, 2021

Could you please take a look on new build warnings from "Custom" (CUDA) builder?

not related to this PR

@opencv-pushbot opencv-pushbot merged commit 49ea864 into opencv:4.x Nov 12, 2021
@JulieBar JulieBar deleted the remap_overflow branch November 21, 2021 01:21
@alalek alalek mentioned this pull request Dec 30, 2021
@alalek alalek mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants