Skip to content

EdgeDrawing: Add output of segment index for line detection #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

ToFam
Copy link
Contributor

@ToFam ToFam commented Dec 9, 2021

Simply adds an optional output to EdgeDrawing lineDetect() for getting the edge segment each line lies on.
I need this for porting the STag library

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Member

alalek commented Dec 9, 2021

/cc @sturkmen72

@sturkmen72
Copy link
Contributor

@ToFam proposed changes looks good but i propose sturkmen72@c7951ed because in my opinion adding additional features like CihanTopal/ED_Lib#28 will be easier.

@ToFam
Copy link
Contributor Author

ToFam commented Dec 9, 2021

@sturkmen72 Sure, whatever works best. Thank you.

@ToFam
Copy link
Contributor Author

ToFam commented Dec 10, 2021

@sturkmen72 should I update my pr or are you going to push yours?

@sturkmen72
Copy link
Contributor

@ToFam could you update your PR please. you could enrich the documentation see also sturkmen72@3a2127d

@sturkmen72
Copy link
Contributor

@alalek looks good to me, please review.
@ToFam could you rebase commits into one.

@ToFam ToFam force-pushed the ed_segment_getter branch from e0f2bf9 to e90e9fc Compare December 13, 2021 18:10
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍

@sturkmen72 Thank you for the review!

@opencv-pushbot opencv-pushbot merged commit eed990a into opencv:4.x Dec 13, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
@alalek alalek mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants