-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Use texture Object to make cv::cuda::HoughSegmentDetectorImpl::detect() thread-safe #3185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The macOS test build that fails does not appear to be related to any modules in this change. Or am I missing something here? |
@alalek or any other maintainers, can you please help us get the CI passing? It is not clear how the change from this PR would impact the test from a different module, and then only on macOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I re-triggered CI build on Mac. Let's wait for status. |
Looks like CI now all passing thanks for re-triggering the build @asmorkalov |
Signed-off-by: Ron Evans <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all requested changes have now been made, and also all CI tests are now passing green.
This PR fixes #3184 by using texture Object to make
cv::cuda::HoughSegmentDetectorImpl::detect()
thread-safe.This PR also includes unit test for probabilistic hough segment detector. Previously, there was no unit test for this function.
Also note that, this solution is only thread-safe for
CV_CUDEV_ARCH>=300
. This is the same solution as existing code for canny algorithm that is already part ofopencv_contrib
. See here : 6ca24c8Pull Request Readiness Checklist
Patch to opencv_extra has the same branch name.