Skip to content

Fix cudacodec and cudastereo python bindings #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

cudawarped
Copy link
Contributor

@cudawarped cudawarped commented Jun 1, 2022

The python bindings for cudastero::reprojectImageTo3D (see https://forum.opencv.org/t/cv2-cuda-reprojectimageto3d-dispcu-q-error-5-bad-argument/5242) and some newere methods in cudacodec::VideoReader and are not functioning correctly.

The PR fixes this issue and adds tests to check the input output functionality.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Member

alalek commented Jun 2, 2022

@cudawarped Please rebase this PR to resolve conflicts (related to #3247)

@cudawarped cudawarped force-pushed the fix_python_bindings branch from 061a205 to d276079 Compare June 2, 2022 12:36
@cudawarped
Copy link
Contributor Author

@alalek Done.

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 442085f into opencv:4.x Jun 4, 2022
@alalek alalek mentioned this pull request Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants