Skip to content

Update Macbeth Dictionary #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Update Macbeth Dictionary #3297

merged 1 commit into from
Nov 27, 2022

Conversation

wpwupingwp
Copy link
Contributor

In Macbeth colorchecker dictionary, the RGB value of 21.neutral 6.5(.44*) and 23.neutral 3.5(.1.05*) seems to be wrong, while Lab values are correct.

Citation: https://babelcolor.com/index_htm_files/RGB%20Coordinates%20of%20the%20Macbeth%20ColorChecker.pdf

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

In Macbeth colorchecker, the RGB value of 21.neutral 6.5(.44*) and 23.neutral 3.5(.1.05*) seems to be wrong, while Lab values are correct.

Citation: https://babelcolor.com/index_htm_files/RGB%20Coordinates%20of%20the%20Macbeth%20ColorChecker.pdf
@asmorkalov asmorkalov changed the title Update dictionary.hpp Update Macbeth Dictionary Jul 4, 2022
@vpisarev vpisarev self-requested a review November 27, 2022 14:23
@vpisarev
Copy link
Contributor

thank you! 👍

@vpisarev vpisarev merged commit d6102ef into opencv:4.x Nov 27, 2022
@wpwupingwp wpwupingwp deleted the patch-1 branch November 28, 2022 02:57
@alalek alalek mentioned this pull request Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants