Skip to content

Use T as temp var type in polyanticlockwise() #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

y-guyon
Copy link
Contributor

@y-guyon y-guyon commented Aug 9, 2022

To match the input data type.
Cast inner computation to double to prevent int overflows for any input type.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work (the input image triggering the overflow is not publicly available)
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

To match the input data type.
Cast inner computation to double to prevent int overflows for any
input type.
@asmorkalov asmorkalov added the category: mcc color calibration module label Aug 12, 2022
@y-guyon y-guyon requested a review from asmorkalov September 1, 2022 09:36
@asmorkalov
Copy link
Contributor

@y-guyon please take a look on CI. The patch breaks build.

@y-guyon
Copy link
Contributor Author

y-guyon commented Sep 5, 2022

@y-guyon please take a look on CI. The patch breaks build.

Yes thanks, I received the GitHub notification by email.
I moved the definitions to the .cc file now that they are not templated anymore.

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-assigned this Sep 5, 2022
@asmorkalov asmorkalov merged commit 7a42990 into opencv:4.x Sep 5, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: mcc color calibration module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants