Skip to content

Fix CUDA mem leak in GFTT and move CUDA malloc out of critical path #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

kevinchristensen1
Copy link
Contributor

@kevinchristensen1 kevinchristensen1 commented Aug 10, 2022

Fixes #3042, also mentioned in #2868
Also added a fix for #3194
Fixes cuda mem leak in GoodFeaturesToTrackDetector and moves cuda malloc/free into the ctor/dtor, out of critical path

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

@kevinchristensen1
Copy link
Contributor Author

Thanks for reviewing Alex! It looks like the macOS-ARM64 CI build is failing due to a timeout issue unrelated to this patch. Is there anything else I need to do?

@asmorkalov asmorkalov merged commit c5f4dff into opencv:4.x Aug 12, 2022
@alalek alalek mentioned this pull request Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is there has memory leak?
2 participants