xphoto fix inpaint fsr #3336
Merged
xphoto fix inpaint fsr #3336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berak
force-pushed
the
xphoto_fix_inpaint_fsr
branch
from
cb23a0e to
4fe1b50
Compare
asmorkalov
reviewed
Aug 29, 2022
berak
force-pushed
the
xphoto_fix_inpaint_fsr
branch
from
4fe1b50 to
be8db6a
Compare
asmorkalov
reviewed
Sep 29, 2022
| @@ -767,7 +767,7 @@ void inpaint_fsr(const Mat &src, const Mat &mask, Mat &dst, const int algorithmT | |||
| CV_Error(Error::StsUnsupportedFormat, "Unsupported source image format!"); | |||
| break; | |||
| } | |||
| src.convertTo(src, CV_8U, 1/257.0); | |||
| src.convertTo(src, CV_8U, 1/255.0); | |||
There was a problem hiding this comment.
In case if you want to get only higher 8 bits of value, the multiplier should be 1/256.
There was a problem hiding this comment.
sure, 16 bit block ...
berak
force-pushed
the
xphoto_fix_inpaint_fsr
branch
from
be8db6a to
4057993
Compare
asmorkalov
approved these changes
Sep 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2855
use a temporal Mat header for convertTo()
Pull Request Readiness Checklist
(this goes to the 4.x branch, there is no fsr inpainting in 3.4)