Skip to content

fix the bug that cannot detect multi qrcode when use_nn_detector is false #3342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

bit1002lst
Copy link
Contributor

@bit1002lst bit1002lst commented Aug 27, 2022

Pull Request Readiness Checklist

related issus #3343 3343
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@bit1002lst
Copy link
Contributor Author

bit1002lst commented Aug 28, 2022

The change can be tested by the original test files.
The test img should have two or more qrcodes(such as
https://ts1.cn.mm.bing.net/th/id/R-C.fdec3dd2484aa10f9785cd460f17b418?rik=PaTvAy4%2b2VgBWA&riu=http%3a%2f%2fimg3.redocn.com%2ftupian%2f20150423%2ferweimashiliangsucai_4006416.jpg&ehk=KYk2bfwKcIwpF3fB45Aj2PhlwKhbJe8%2bgtHcEZC2CZk%3d&risl=&pid=ImgRaw&r=0) and set detector_prototxt_path / detector_caffe_model_path / super_resolution_prototxt_path / super_resolution_caffe_model_path
be empty.

@AleksandrPanov
Copy link
Contributor

@bit1002lst, need add test to approve PR

@bit1002lst bit1002lst marked this pull request as draft September 2, 2022 12:21
@bit1002lst bit1002lst marked this pull request as ready for review September 3, 2022 15:57
@asmorkalov
Copy link
Contributor

OpenCV team uses GTest to implement unit tests and run them automatically. WeChat related tests are here: https://github.com/opencv/opencv_contrib/blob/4.x/modules/wechat_qrcode/test/test_qrcode.cpp. There is test for multiple qr codes, but it's disabled by some reason. @AleksandrPanov Please restore the test and they it could be extended to test both cases.

@asmorkalov
Copy link
Contributor

@bit1002lst Could you rebase the patch on top of 4.x and fix the conflicts. Yet another patch for We chat module was just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants