Fix opencv issue #22721 #3380
Fix opencv issue #22721 #3380
Conversation
cudawarped
force-pushed
the
fix_video_writer_python_bindings
branch
from
61ccc36 to
9b87bed
Compare
| @@ -61,12 +61,6 @@ GUID EncodingProfileGuid(const EncodeProfile encodingProfile); | |||
| GUID EncodingPresetGuid(const EncodePreset nvPreset); | |||
| bool Equal(const GUID& g1, const GUID& g2); | |||
|
|
|||
| EncoderParams::EncoderParams() : nvPreset(ENC_PRESET_P3), tuningInfo(ENC_TUNING_INFO_HIGH_QUALITY), encodingProfile(ENC_CODEC_PROFILE_AUTOSELECT), | |||
There was a problem hiding this comment.
There are should be implementation in the #else branch:
#else // !defined HAVE_NVCUVENC
... CV_Error(...NotImplemented...) implementation stubs for public API ...
There was a problem hiding this comment.
createVideoWriter has this else branch. With the changes parameters structure could be created correctly without linker issue, but createVideoWriter raises the issue. I propose to merge the PR as is.
There was a problem hiding this comment.
I moved it to the header to mirror the way cudacodec::FormatInfo() is implemented.
Both structs can exist without the Nvidia Video Coded SDK being installed whether they should or not is a different matter. Do you want me to move the implementation of both into the .cpp and prevent their use when HAVE_NVCUVENC and/or HAVE_NVCUVID are not defined?
There was a problem hiding this comment.
I prefer to have config structures always available how it's done in PR.
Fix opencv/opencv#22721 (comment)
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.