Add readiness and liveness probes

[skonto]

• Follows the approach here. Tested with a deployment. Uses the standard paths: /livez & /readyz, exposed by c-r.
• We need this especially for integration tests to make sure everything is setup (monitoring is not covered due to the lack of this).
  /cc @markusthoemmes @aliok

[markusthoemmes]

/test 4.6-upgrade-tests-aws-ocp-46

For once I'd like to see upgrade test passing.

[skonto]

/test 4.6-upgrade-tests-aws-ocp-46

[skonto]

@markusthoemmes all tests passed but it failed again.

[skonto]

@markusthoemmes I think we can merge this one.

[markusthoemmes]

I'd like the upgrade test to at least run once. Damn infra issues...

/test 4.6-upgrade-tests-aws-ocp-46

[skonto]

Right now we are hitting the issue of the leader deadlock when using osdk: new pod passes Become if it becomes a leader but the old pod will not release that lock to allow that until the new pod becomes ready which will never happen (can happen after Become). Hopefully the c-r leader election mechanism will solve this, upgrade tests should pass if that is true.

[skonto]

/retest

[skonto]

/retest

[skonto]

21:20:04.620 INFO:    Wait for the index pod to be up to avoid inconsistencies with the catalog source.
21:20:04.622 DEBUG:   [[ $(oc get pods -l app=serverless-index -n openshift-marketplace -o name | wc -l) == '0' ]] : Waiting until non-zero (max 300 sec.)
done
21:20:15.764 DEBUG:   [[ $(oc get pods -l app=serverless-index -n openshift-marketplace -o 'jsonpath={..status.conditions[?(@.type=="Ready")].status}') != 'True' ]] : Waiting until non-zero (max 300 sec.)
.............................................................................................................................................................................................................................................................................................................
22:21:47.084 ERROR:   Time out of 300 exceeded

[skonto]

/retest

[markusthoemmes]

^^ Is a compile error in eventing, supposed to be fixed via openshift/knative-eventing#957. Sadly we need to wait for this as this hasn't yet tested upgradeability at this point.

[markusthoemmes]

/retest

Compile error is hopefully gone.

[markusthoemmes]

/lgtm
/approve

Off you go!

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markusthoemmes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment