Make sure namespaces are created before start testing

[nak3]

As build log exposed, sometimes tests fail due to namespace not found error.

=== RUN   TestKnativeEventing/create_subscription_and_wait_for_CSV_to_succeed
=== RUN   TestKnativeEventing/deploy_knativeeventing_cr_and_wait_for_it_to_be_ready
    knative_eventing_test.go:39: Failed to deploy KnativeEventing namespaces "knative-eventing" not found
--- FAIL: TestKnativeEventing (61.82s)

It seems too early to start testing after CatalogSource was created.

04:46:15.341 SUCCESS: CatalogSource installed successfully
04:46:15.343 SUCCESS: 🚀 Cluster prepared for testing.
04:46:15.345 INFO:    Running tests

Hence this patch makes sure namespaces are created in install_catalogsource().

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nak3
To complete the pull request process, please assign aliok after the PR has been reviewed.
You can assign the PR to them by writing /assign @aliok in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mgencur]

@nak3 noticed this problem too but I think knative-serving and knative-eventing namespaces are created automatically when you install the Subscription? I don't think waiting for the namespaces after installing catalog source will help. We discussed that with Markus here: https://coreos.slack.com/archives/CD87JDUB0/p1604477220246200

[markusthoemmes]

Let's hold off on this until #660 lands and see if that fixes it. Readiness probes are the "proper" fix here.

[openshift-merge-robot]

@nak3: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/4.6-operator-e2e-aws-ocp-46	6440023	link	/test 4.6-operator-e2e-aws-ocp-46
ci/prow/4.6-upstream-e2e-aws-ocp-46	6440023	link	/test 4.6-upstream-e2e-aws-ocp-46
ci/prow/4.6-upgrade-tests-aws-ocp-46	6440023	link	/test 4.6-upgrade-tests-aws-ocp-46

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[skonto]

@markusthoemmes I tried the readiness stuff locally and it solved it at least on my side.

[nak3]

Thank you. I am closing this. And actually as Martin pointed out, this PR is wrong 😅