Skip to content

Conversation

RishabhSaini
Copy link
Contributor

@RishabhSaini RishabhSaini commented Sep 2, 2025

This promotes the ManagedBootImagesvSphere feature gate to Default

Sippy Dashboard
Origin PR

Copy link
Contributor

openshift-ci bot commented Sep 2, 2025

Hello @RishabhSaini! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@RishabhSaini RishabhSaini changed the title Lift default fg for ManagedBootImagesvSphere Lift fg for ManagedBootImagesvSphere Sep 2, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2025
Copy link
Contributor

openshift-ci bot commented Sep 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RishabhSaini
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RishabhSaini RishabhSaini changed the title Lift fg for ManagedBootImagesvSphere Promote ManagedBootImagesvSphere feature gate to default Sep 2, 2025
@RishabhSaini RishabhSaini changed the title Promote ManagedBootImagesvSphere feature gate to default MCO-1861: Promote ManagedBootImagesvSphere feature gate to default Sep 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2025

@RishabhSaini: This pull request references MCO-1861 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This promotes the ManagedBootImagesvSphere feature gate to Default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2025

@RishabhSaini: This pull request references MCO-1861 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This promotes the ManagedBootImagesvSphere feature gate to Default

Sippy Dashboard
Origin PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Contributor

@RishabhSaini Test pass rates are looking good, but we would normally expect to see 14 runs minimum. Are the periodic tests running daily at the moment? If you believe the feature is ready to go sooner, you can use gangway-cli to trigger 10 runs of the periodic job to boost the numbers

@RishabhSaini
Copy link
Contributor Author

/test verify-feature-promotion

Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

@RishabhSaini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 7122337 link false /test e2e-azure
ci/prow/e2e-aws-serial-2of2 7122337 link true /test e2e-aws-serial-2of2
ci/prow/e2e-aws-ovn-hypershift 7122337 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial-techpreview-2of2 7122337 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-upgrade-out-of-change 7122337 link true /test e2e-upgrade-out-of-change
ci/prow/e2e-gcp 7122337 link false /test e2e-gcp
ci/prow/verify-feature-promotion 7122337 link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RishabhSaini
Copy link
Contributor Author

@JoelSpeed I triggered 10 tests and they are all green on the Sippy dashboard

@JoelSpeed
Copy link
Contributor

@RishabhSaini Does the periodic test you've added also exist for 4.21? I can see the results for the 4.20 periodic look good, but it doesn't appear that there is any data for 4.21, any ideas?

@RishabhSaini
Copy link
Contributor Author

RishabhSaini commented Sep 5, 2025

I am unable to trigger this job in 4.21:

> ./gangway-cli --api-url="https://gangway-ci.apps.ci.l2s4.p1.openshiftapps.com/" --initial "registry.ci.openshift.org/ocp/release:4.21.0-0.nightly-2025-09-01-065329" --latest "registry.ci.openshift.org/ocp/release:4.21.0-0.nightly-2025-09-01-065329" --job-name periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-vsphere-mco-disruptive-techpreview --num-jobs 10

Looks like periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-vsphere-mco-disruptive-techpreview job does not exist in 4.21

https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-vsphere-mco-disruptive-techpreview gives error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants