MCO-1656: Component Readiness for vSphere Bootimage Update #29741
Conversation
|
@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
openshift-ci
bot
removed
the
approved
|
@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Job Failure Risk Analysis for sha: a5da303
|
|
@RishabhSaini: This pull request references MCO-1656 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
RishabhSaini
force-pushed
the
vsphere
branch
2 times, most recently
from
678a799 to
4b9091c
Compare
|
Job Failure Risk Analysis for sha: 4b9091c
|
RishabhSaini
force-pushed
the
vsphere
branch
3 times, most recently
from
4147550 to
761339a
Compare
|
Job Failure Risk Analysis for sha: 761339a
|
|
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
|
@RishabhSaini: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7badb410-7398-11f0-9462-146da25a8999-0 |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-techpreview-serial |
|
@RishabhSaini: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a0ca2170-7398-11f0-84fc-f3f24adfe5a9-0 |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-vsphere-mco-disruptive-techpreview |
|
@RishabhSaini: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6714a450-73bb-11f0-9bdb-70a8740b9f01-0 |
RishabhSaini
force-pushed
the
vsphere
branch
2 times, most recently
from
b7b039b to
5071a53
Compare
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-vsphere-mco-disruptive-techpreview |
|
@RishabhSaini: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e785ba50-7890-11f0-9a65-ffc7237d6591-0 |
|
Job Failure Risk Analysis for sha: 801bb9d
|
|
Job Failure Risk Analysis for sha: 801bb9d
|
1 similar comment
|
Job Failure Risk Analysis for sha: 801bb9d
|
|
/payload-aggregate periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-vsphere-mco-disruptive-techpreview 5 |
|
@RishabhSaini: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/49915880-791d-11f0-827d-c40867772aba-0 |
|
/payload-aggregate periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-vsphere-mco-disruptive-techpreview 3 |
|
@RishabhSaini: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/77547160-7951-11f0-8dd6-e505e324de24-0 |
|
/payload-aggregate periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-vsphere-mco-disruptive-techpreview 5 |
|
@RishabhSaini: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/946de5e0-79e4-11f0-9003-fd9d5ede5762-0 |
| func diffNewPods(before, after map[string]struct{}) []string { | ||
| var newPods []string | ||
| for pod := range after { | ||
| if _, found := before[pod]; !found { | ||
| newPods = append(newPods, pod) | ||
| } | ||
| } | ||
| return newPods | ||
| } | ||
|
|
||
| func getMCDPodSet(oc *exutil.CLI) (map[string]struct{}, error) { | ||
| out, err := oc.Run("get").Args( | ||
| "pods", | ||
| "-n", "openshift-machine-config-operator", | ||
| "-l", "k8s-app=machine-config-daemon", | ||
| "-o", "go-template={{range .items}}{{.metadata.name}}{{\"\\n\"}}{{end}}", | ||
| ).Output() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get pods: %v", err) | ||
| } | ||
|
|
||
| podSet := make(map[string]struct{}) | ||
| lines := strings.Split(out, "\n") | ||
| for _, line := range lines { | ||
| name := strings.TrimSpace(line) | ||
| if name != "" { | ||
| podSet[name] = struct{}{} | ||
| } | ||
| } | ||
| return podSet, nil | ||
| } |
There was a problem hiding this comment.
Non blocking, but we could use sets here to simplify the logic. We have a few examples in our repo if you want to take a crack at it 😄
| // Fetch the providerSpec of the machineset under test again | ||
| providerSpecDisks, err := oc.Run("get").Args(mapiMachinesetQualifiedName, machineSet.Name, "-o", "template", "--template=`{{.spec.template.spec.providerSpec.value}}`", "-n", mapiNamespace).Output() | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| o.Eventually(func() bool { |
There was a problem hiding this comment.
Hmm, is this Eventually still needed after the WaitForBootImageControllerToComplete timeout bump? Not a huge deal if we want to keep it, just checking.
|
@RishabhSaini: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 17679e8
|
1 similar comment
|
Job Failure Risk Analysis for sha: 17679e8
|
|
/lgtm Discussed with Rishabh out of band and we concluded that we try to fix the non blocking threads above as follow-ups. Let's get these tests in to get some signal. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, neisw, RishabhSaini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 1bac1f6
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
Status:
Verified that the new tests for vSphere are passing.
Currently it needs the following PRs to execute correctly:
Needed for the
ManagedBootImagesvSphereFeatureGateValidationAdmissionPolicy
managed-bootimages-platform-checkto allowVSphereas the BootImageUpdatePlatform.