Consistent log messages #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/M
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
ingvagabund
reviewed
Mar 6, 2019
| @@ -399,7 +399,6 @@ func checkFlags(cmd *cobra.Command) error { | |||
| func main() { | |||
| err := rootCmd.Execute() | |||
| if err != nil { | |||
| fmt.Fprintf(os.Stderr, "Error occurred: %v\n", err) | |||
| os.Exit(1) | |||
| glog.Fatalf("Error occurred: %v", err) | |||
cmd/manager/main.go
Outdated
| @@ -44,7 +44,7 @@ func main() { | |||
| glog.Fatal(err) | |||
| } | |||
|
|
|||
| glog.Infof("Registering Components.") | |||
| glog.Info("Registering Components.") | |||
There was a problem hiding this comment.
Without the dot at the end please
cmd/manager/main.go
Outdated
| @@ -61,10 +61,13 @@ func main() { | |||
| glog.Fatal(err) | |||
| } | |||
|
|
|||
| glog.Infof("Starting the Cmd.") | |||
| glog.Info("Starting the Cmd.") | |||
There was a problem hiding this comment.
Without the dot at the end please
| @@ -109,7 +109,7 @@ func (a *Actuator) handleMachineError(machine *machinev1.Machine, err *apierrors | |||
|
|
|||
| // Create creates a machine and is invoked by the Machine Controller | |||
| func (a *Actuator) Create(context context.Context, cluster *machinev1.Cluster, machine *machinev1.Machine) error { | |||
| glog.Infof("Creating machine %q", machine.Name) | |||
| glog.Infof("Creating machine %v", machine.Name) | |||
| @@ -149,7 +149,7 @@ func (a *Actuator) Create(context context.Context, cluster *machinev1.Cluster, m | |||
|
|
|||
| // Delete deletes a machine and is invoked by the Machine Controller | |||
| func (a *Actuator) Delete(context context.Context, cluster *machinev1.Cluster, machine *machinev1.Machine) error { | |||
| glog.Infof("Deleting machine %q", machine.Name) | |||
| glog.Infof("Deleting machine %v", machine.Name) | |||
| @@ -373,7 +373,7 @@ func (a *Actuator) applyMachineStatus( | |||
| return nil | |||
| } | |||
|
|
|||
| glog.Infof("Machine %s status has changed: %s", machine.Name, diff.ObjectReflectDiff(machine.Status, machineCopy.Status)) | |||
| glog.Infof("Machine %s status has changed: %v", machine.Name, diff.ObjectReflectDiff(machine.Status, machineCopy.Status)) | |||
pkg/cloud/libvirt/client/domain.go
Outdated
| diskVolume, err := virConn.LookupStorageVolByKey(volumeKey) | ||
| if err != nil { | ||
| return fmt.Errorf("Can't retrieve volume %s", volumeKey) | ||
| } | ||
| glog.Infof("diskVolume") | ||
| glog.Info("diskVolume") |
There was a problem hiding this comment.
Strange log messages. Maybe Getting disk volume or similar.
pkg/cloud/libvirt/client/domain.go
Outdated
| @@ -267,18 +267,18 @@ func randomWWN(strlen int) string { | |||
|
|
|||
| func setDisks(domainDef *libvirtxml.Domain, virConn *libvirt.Connect, volumeKey string) error { | |||
| disk := newDefDisk(0) | |||
| glog.Infof("LookupStorageVolByKey") | |||
| glog.Info("LookupStorageVolByKey") | |||
There was a problem hiding this comment.
Rather Looking up storage volume by key
pkg/cloud/libvirt/client/domain.go
Outdated
| diskVolumeFile, err := diskVolume.GetPath() | ||
| if err != nil { | ||
| return fmt.Errorf("Error retrieving volume file: %s", err) | ||
| } | ||
|
|
||
| glog.Infof("DomainDiskSource") | ||
| glog.Info("DomainDiskSource") |
There was a problem hiding this comment.
Constructing domain disk source
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on openshift/machine-api-operator#231
/assign @ingvagabund