Logging and events #231
Logging and events #231
Conversation
openshift-ci-robot
added
the
size/L
cmd/machine-api-operator/start.go
Outdated
| @@ -67,7 +67,7 @@ func runStartCmd(cmd *cobra.Command, args []string) { | |||
| Callbacks: leaderelection.LeaderCallbacks{ | |||
| OnStartedLeading: run, | |||
| OnStoppedLeading: func() { | |||
| glog.Fatalf("leaderelection lost") | |||
| glog.Fatalf("leader election lost") | |||
There was a problem hiding this comment.
Awkward one, but I tend to go with: https://github.com/golang/go/wiki/CodeReviewComments#error-strings
enxebre
force-pushed
the
logging-events
branch
from
dd7ee06 to
143dbc5
Compare
|
I think the "rules" would be simpler if it was lower always. With that simple rule there's no ambiguity. Code reviews go faster because there's only 1 rule. Error message and Warning messages and Info messages are consistently formatted. It is also idiomatic Go [1]. [1] - https://github.com/golang/go/wiki/CodeReviewComments#error-strings |
|
/test integration |
|
/test integration |
|
/test integration |
|
fixes integration #233 |
enxebre
force-pushed
the
logging-events
branch
from
143dbc5 to
10d6daf
Compare
|
/test integration |
| var message string | ||
| if !reflect.DeepEqual(desiredVersions, currentVersions) { | ||
| glog.V(2).Info("Syncing status: progressing") | ||
| message = fmt.Sprintf("Progressing towards %s", optr.printOperandVersions()) | ||
| optr.eventRecorder.Eventf(co, v1.EventTypeNormal, "Status upgrade", message) |
There was a problem hiding this comment.
Status upgraded or Status upgraging maybe?
|
Does it make sense to report |
enxebre
force-pushed
the
logging-events
branch
from
10d6daf to
66e2c50
Compare
cmd/nodelink-controller/main.go
Outdated
| modNode.Labels[k] = v | ||
| } | ||
|
|
||
| addTaintsToNode(modNode, matchingMachine) | ||
|
|
||
| if !reflect.DeepEqual(node, modNode) { | ||
| glog.V(3).Infof("node has changed, updating") | ||
| glog.V(3).Infof("Node has changed, updating") |
There was a problem hiding this comment.
If we're going to log we might as well indicate which node.
enxebre
force-pushed
the
logging-events
branch
from
66e2c50 to
a5b6fb5
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Improve logging and add events for the operator cluster status
Conventions: