fix(controller-runtime): fix metricsprovider wiring #2354
Conversation
Upstream controller-runtime does not provide a way to pass a metricsprovider when creating a Controller. This results in metrics/workqueue not being exported. Signed-off-by: Antoni Segura Puimedon <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: celebdor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Yes, this gels with what we discussed 👍 |
|
We expect |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2354 +/- ##
=======================================
Coverage 58.51% 58.51%
=======================================
Files 182 182
Lines 25884 25884
=======================================
Hits 15147 15147
Misses 9460 9460
Partials 1277 1277 |
|
@celebdor: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-job-with-prs periodic-ci-openshift-hive-master-periodic-e2e-gcp-weekly openshift/api#1958 openshift/installer#8723 |
|
@2uasimojo: the repo openshift/hive does not contribute to the OpenShift official images |
|
We went with a different temporary fix (#2355). This one may still help inform what we want the upstream fix to look like. |
Upstream controller-runtime does not provide a way to pass a metricsprovider when creating a Controller. This results in metrics/workqueue not being exported.