Remove redundant import of generic admission server cmd

[JoelSpeed]

I have no idea why this package was imported, but, at present, importing this package imports a single Go file which does not have an init function, but, does pull in other packages that eventually do have init functions.

The result of this being imported in main.go is that it ends up calling the component base metrics workqueue stuff first, which means the controller-runtime stuff doesn't win the race currently.

This removal could have unintended side effects if there are other init functions that we are relying on, but it does remove the component-base workqueue metrics from the init tree, fixing the metrics issue at hand. If there are other inits that we are relying on, perhaps those packages should be imported explicitly rather than implicitly as they are today anyway?

Suggest to go through some testing before merge.

HIVE-2543

[openshift-ci]

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.51%. Comparing base (1fce770) to head (7fd94ee).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2355   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files         182      182           
  Lines       25884    25884           
=======================================
  Hits        15147    15147           
  Misses       9460     9460           
  Partials     1277     1277           

[2uasimojo]

This seems to resolve the problem:

[efried@efried hive]$ oc port-forward -n hive service/hive-machinepool 2112:2112 &
[1] 17638
Forwarding from 127.0.0.1:2112 -> 2112
[efried@efried hive]$ curl localhost:2112/metrics|grep workqueue_queue

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0Handling connection for 2112
100 19154    0 19154    0     0  88675      0 --:--:-- --:--:-- --:--:-- 886# HELP workqueue_queue_duration_seconds How long in seconds an item stays in workqueue before being requested
75
# TYPE workqueue_queue_duration_seconds histogram
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="1e-08"} 0
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="1e-07"} 0
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="1e-06"} 0
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="9.999999999999999e-06"} 4
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="9.999999999999999e-05"} 7
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="0.001"} 11
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="0.01"} 11
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="0.1"} 11
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="1"} 13
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="10"} 13
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="100"} 13
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="1000"} 13
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="+Inf"} 13
workqueue_queue_duration_seconds_sum{name="machinepool-controller"} 0.217071048
workqueue_queue_duration_seconds_count{name="machinepool-controller"} 13

We'll want a more thorough (upstream) solution eventually, but this gets us past the present hurdle. Thanks @JoelSpeed !

/lgtm

/override "Red Hat Konflux / hive-on-pull-request"

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [2uasimojo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@2uasimojo: Overrode contexts on behalf of 2uasimojo: Red Hat Konflux / hive-on-pull-request

In response to this:

This seems to resolve the problem:

[efried@efried hive]$ oc port-forward -n hive service/hive-machinepool 2112:2112 &
[1] 17638
Forwarding from 127.0.0.1:2112 -> 2112
[efried@efried hive]$ curl localhost:2112/metrics|grep workqueue_queue

 % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                Dload  Upload   Total   Spent    Left  Speed
 0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0Handling connection for 2112
100 19154    0 19154    0     0  88675      0 --:--:-- --:--:-- --:--:-- 886# HELP workqueue_queue_duration_seconds How long in seconds an item stays in workqueue before being requested
75
# TYPE workqueue_queue_duration_seconds histogram
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="1e-08"} 0
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="1e-07"} 0
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="1e-06"} 0
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="9.999999999999999e-06"} 4
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="9.999999999999999e-05"} 7
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="0.001"} 11
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="0.01"} 11
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="0.1"} 11
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="1"} 13
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="10"} 13
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="100"} 13
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="1000"} 13
workqueue_queue_duration_seconds_bucket{name="machinepool-controller",le="+Inf"} 13
workqueue_queue_duration_seconds_sum{name="machinepool-controller"} 0.217071048
workqueue_queue_duration_seconds_count{name="machinepool-controller"} 13

We'll want a more thorough (upstream) solution eventually, but this gets us past the present hurdle. Thanks @JoelSpeed !

/lgtm

/override "Red Hat Konflux / hive-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[2uasimojo]

Workaround for kubernetes-sigs/controller-runtime#2238