USHIFT-4278: Specify default value for .storage.optionalCsiComponents that is an accepted value #3914
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@copejon: This pull request references USHIFT-4278 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/retest |
copejon
force-pushed
the
ushift-4278
branch
from
1352182 to
50ff29f
Compare
openshift-ci
bot
added
the
qe-approved
|
@copejon: This pull request references USHIFT-4278 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
copejon
force-pushed
the
ushift-4278
branch
from
f67ec4c to
a7cfe8d
Compare
|
/cherry-pick release-4.17 |
|
@copejon: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
copejon
force-pushed
the
ushift-4278
branch
from
a7cfe8d to
11bd329
Compare
|
/test verify |
|
@copejon: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@pmtk I reverted the comment fix. The format was ping as an error by the verify script 🤷🏻 |
This reverts commit 72afe2181f62a02dc68003a92d2ace10f43779c2. Update packaging/microshift/config.yaml Co-authored-by: Patryk Matuszak <[email protected]> include [""] as a valid value for optionalCsiComponents to workaround the way controller-gen interprets an empty array when set as a default Signed-off-by: Jon Cope <[email protected]> generate the default config with an empty array. it was created with an array of 1 element, and empty str, which is not an accepted value Signed-off-by: Jon Cope <[email protected]>
copejon
force-pushed
the
ushift-4278
branch
from
ca23770 to
b5333f7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@copejon: new pull request created: #3977 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.