Skip to content

OSDOCS-11169: making CSI optional for microshift #80823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

OSDOCS-11169: making CSI optional for microshift #80823

merged 1 commit into from
Sep 23, 2024

Conversation

aravipra
Copy link
Contributor

@aravipra aravipra commented Aug 22, 2024 •
edited
Loading

Version(s):
4.17+

Issue:
OSDOCS-11169

Link to docs preview:
Disabling and uninstalling LVMS CSI provider and CSI snapshot deployments
Disabling LVMS CSI provider and CSI snapshot

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 22, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11169 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s):
4.17+

Issue:
OSDOCS-11169

Link to docs preview:

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 22, 2024
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 22, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 22, 2024 •
edited
Loading

🤖 Thu Sep 19 09:30:27 - Prow CI generated the docs preview:

https://80823--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-disable-lvms-csi-provider-csi-snapshot.html
https://80823--ocpdocs-pr.netlify.app/microshift/latest/microshift_storage/microshift-storage-plugin-overview.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 22, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11169 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s):
4.17+

Issue:
OSDOCS-11169

Link to docs preview:
Making LVMS and CSI volume snapshot optional

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added this to the Planned for 4.17 GA milestone Aug 26, 2024
copejon
copejon reviewed Aug 26, 2024
View reviewed changes
copejon
copejon reviewed Aug 26, 2024
View reviewed changes
copejon
copejon reviewed Aug 26, 2024
View reviewed changes
copejon
copejon reviewed Aug 26, 2024
View reviewed changes
copejon
copejon reviewed Aug 26, 2024
View reviewed changes
@aravipra aravipra force-pushed the OSDOCS-11169 branch 3 times, most recently from 54cb750 to aa23221 Compare August 27, 2024 12:21
@aravipra
Copy link
Contributor Author

/retest

2 similar comments
@aravipra
Copy link
Contributor Author

/retest

@aravipra
Copy link
Contributor Author

/retest

copejon
copejon reviewed Aug 28, 2024
View reviewed changes
@copejon
Copy link
Contributor

copejon commented Aug 28, 2024

1 nit, but otherwise lgtm!

radeore
radeore reviewed Aug 29, 2024
View reviewed changes
radeore
radeore reviewed Aug 29, 2024
View reviewed changes
radeore
radeore reviewed Aug 29, 2024
View reviewed changes
@radeore
Copy link

radeore commented Aug 29, 2024

Suggested few changes, other LGTM. Thanks!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 30, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11169 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s):
4.17+

Issue:
OSDOCS-11169

Link to docs preview:
Making LVMS and CSI volume snapshot optional

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aravipra
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 30, 2024
@aravipra aravipra mentioned this pull request Aug 30, 2024
Merged
2 tasks
copejon
copejon reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@copejon copejon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions but otherwise it looks good!

@aravipra aravipra force-pushed the OSDOCS-11169 branch 3 times, most recently from 19917aa to 00f28ba Compare September 18, 2024 12:13
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Sep 18, 2024
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Sep 18, 2024
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Sep 18, 2024
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Sep 18, 2024
View reviewed changes
@aravipra aravipra force-pushed the OSDOCS-11169 branch 2 times, most recently from 9cafa9e to 69d1f4c Compare September 18, 2024 13:22
copejon
copejon reviewed Sep 18, 2024
View reviewed changes
copejon
copejon reviewed Sep 18, 2024
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 19, 2024

@aravipra: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@copejon
Copy link
Contributor

copejon commented Sep 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@dhensel-rh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11169 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s):
4.17+

Issue:
OSDOCS-11169

Link to docs preview:
Disabling and uninstalling LVMS CSI provider and CSI snapshot deployments
Disabling LVMS CSI provider and CSI snapshot

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aravipra
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 23, 2024
@jab-rh jab-rh merged commit 593cf2f into openshift:main Sep 23, 2024
2 checks passed
@jab-rh
Copy link
Contributor

jab-rh commented Sep 23, 2024

/cherry-pick enterprise-4.17

@jab-rh jab-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 23, 2024
@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #82263

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 23, 2024
Merged
@ShaunaDiaz ShaunaDiaz removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfitzmau dfitzmau dfitzmau approved these changes

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

+6 more reviewers

@copejon copejon copejon left review comments

@vwalek vwalek vwalek left review comments

@radeore radeore radeore left review comments

@dhensel-rh dhensel-rh dhensel-rh left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@mffiedler mffiedler mffiedler approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mffiedler mffiedler

@copejon copejon

Labels
branch/enterprise-4.17 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.17 GA
Development

Successfully merging this pull request may close these issues.